Skip to content

Api#68

Merged
elysableu merged 22 commits intomainfrom
api
Dec 11, 2025
Merged

Api#68
elysableu merged 22 commits intomainfrom
api

Conversation

@elysableu
Copy link
Contributor

@elysableu elysableu commented Dec 10, 2025 •
edited
Loading

Type of Change

  • feature ⛲
  • bug fix 🐛
  • documentation update 📃
  • styling 🎨
  • refactor 🧑‍💻
  • testing 🧪

Description

  • SImplify Dataprovider and seperate concerns into RealDataProvider and MockDataProvider
  • Set up helper provide AppData provider
  • Create DataContextType interface file
  • Add index files to @/app/providers, @/types, and @/mocks to handle all exports from these directories from one fiel
  • Update api.ts to include fetchUserCharacters
  • Update api config.ts file with new endpoints and removed high risk endpoints
  • Add extractAll helper method to JSONApiClient

Share the reason(s) for this pull request

What questions do you have/what do you want feedback on?

Related Tickets

Closes #49
Closes #67

Screenshots (if applicable):

Added Test?

  • Yes 🫡
  • No 🙅

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • All tests (previous and new) pass 🥳

How to QA this change:

@elysableu
Simplify DataProvider to be base provider and handle both real and mo…
184bfde 
…ck data
@elysableu
Move DataContextType to types directory and added index file to handl…
0aec707 
…e exports
@elysableu
Create ./DataProvider/index.ts to handle exports
6da92bf
@elysableu
Refine dataprovider to be base for seperate providers
28ec3c0
@elysableu
Create seperate provider to handle mock data
b007a86
@elysableu
Update DataContextType interface
4bc9b10
@elysableu
Update providers export file
864fc5e
@elysableu
Add missed typing
0d30e2d
@elysableu
Created seperate provider to handle data coming in from sg_backend
df4ddbe
@elysableu
Add AppDataProvider to handle which provider is being used
9813efc
@elysableu
Update layout to use new provider flow
f9e1d3a
@elysableu
Add extractAll helper method
7ebb0b6
@elysableu
Update endpoints
b2751c8
@elysableu
Add fetchUserCharacters to api fetch methods
1a5782b
@elysableu
Update test userId
7e46266
@elysableu
Add call to fetchUserCharacters and set context state with characters…
0f5e763 
… roster from sg_backend
@elysableu
Fix typo in endpoints
2b3a72f
@elysableu
Fix linter errors
e81e02f
@elysableu
Fix image element error
9556775
@elysableu
Add .waitForURL to fix test error
c152758
@elysableu
Add wait times to playwright tests
f4c6faf
@elysableu
USE_MOCK_DATA active
5b29971
@elysableu elysableu merged commit 55a8955 into main Dec 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fetch User specific Characters Extract multiple entries

1 participant

@elysableu